-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimize netcollector implementation and custom /proc
mount path
#594
optimize netcollector implementation and custom /proc
mount path
#594
Conversation
Welcome @oif! |
Hi @oif. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6e7a107
to
c1a382a
Compare
/assign @wangzhen127 |
/retest |
/ok-to-test |
67db75a
to
5961758
Compare
/retest |
/cc @vteratipally |
/assign @vteratipally |
@vteratipally Will rely on you for the review. :) |
/unassign @wangzhen127 @andyxning |
5961758
to
44685e2
Compare
/assign @wangzhen127 |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/lgtm |
/test pull-npd-e2e-test |
just wait for #647 to resolve test issues |
/retest-required |
44685e2
to
9c0452f
Compare
@oif: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold |
/retest |
@vteratipally may keep going? |
/test pull-npd-e2e-kubernetes-gce-gci |
/test pull-npd-e2e-kubernetes-gce-gci-custom-flags |
/hold cancel |
9c0452f
to
11ddb5e
Compare
@vteratipally just rebase master branch, tests working. need review(then lgtm) after all test succeeded |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oif, Random-Liu, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Improvements:
/proc
: supports mount host/proc
with a custom path into the NPD container